Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exec credential provider: pre-1.22 stuff (update with shipped metrics API, InteractiveMode API, GA API review) #2587

Merged
merged 3 commits into from
May 11, 2021
Merged

exec credential provider: pre-1.22 stuff (update with shipped metrics API, InteractiveMode API, GA API review) #2587

merged 3 commits into from
May 11, 2021

Conversation

ankeesler
Copy link
Contributor

@ankeesler ankeesler commented Mar 29, 2021 •
edited
Loading

KEP updates needed for this feature set to go GA in 1.22.

1.22 KEP tracking: #541 (comment).

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 29, 2021
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 29, 2021
@ankeesler ankeesler mentioned this pull request Mar 29, 2021
Closed
@ankeesler ankeesler changed the title WIP: exec credential provider: 1.22 stuff (update with shipped metrics API, InteractiveMode) WIP: exec credential provider: pre-1.22 stuff (update with shipped metrics API, InteractiveMode) Apr 13, 2021
@ankeesler ankeesler changed the title WIP: exec credential provider: pre-1.22 stuff (update with shipped metrics API, InteractiveMode) WIP: exec credential provider: pre-1.22 stuff (update with shipped metrics API, InteractiveMode API, GA API review) Apr 28, 2021
@ankeesler
Copy link
Contributor Author

/label api-review

Hey api-review folks - can we put this on your radar for review in 1.22? We'd like the API presented in this KEP to go GA. My understanding is that we would need approval from the API review board to do so. Correct me if I am wrong. :)

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Apr 28, 2021
@liggitt liggitt self-assigned this Apr 28, 2021
@liggitt liggitt added this to the v1.22 milestone Apr 29, 2021
@deads2k
Copy link
Contributor

deads2k commented May 7, 2021

if this PR targets stable in 1.22, please update https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-auth/541.yaml with a stable approver. I remember this KEP from before and I'm available after monday next week.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2021
@ankeesler ankeesler changed the title WIP: exec credential provider: pre-1.22 stuff (update with shipped metrics API, InteractiveMode API, GA API review) exec credential provider: pre-1.22 stuff (update with shipped metrics API, InteractiveMode API, GA API review) May 10, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2021
@deads2k
Copy link
Contributor

deads2k commented May 11, 2021

PRR lgtm. I cannot /approve without accidentally approving the entire thing. Get me on slack once the primary KEP review is completed.

@liggitt
Copy link
Member

liggitt commented May 11, 2021 •
edited
Loading

/lgtm
/approve

(for reference, most of the review comments were done in the implementation PR in kubernetes/kubernetes#99310)

@deads2k
Copy link
Contributor

deads2k commented May 11, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankeesler, deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2021
liggitt
liggitt reviewed May 11, 2021
View reviewed changes
keps/sig-auth/541-external-credential-providers/README.md
Comment on lines +612 to +617
Help: "Number of calls to an exec plugin, partitioned by the type of " +
"event encountered (no_error, plugin_execution_error, plugin_not_found_error, " +
"client_internal_error) and an optional exit code. The exit code will " +
"be set to 0 if and only if the plugin call was successful.",
},
[]string{"code"},
[]string{"code", "call_status"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that this is updating the KEP to reflect what was actually implemented in past releases

@k8s-ci-robot k8s-ci-robot merged commit 304a50c into kubernetes:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@deads2k deads2k Awaiting requested review from deads2k

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@liggitt liggitt

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
API Reviews
Status: API review completed, 1.22
SIG Auth
Archived in project
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@ankeesler @deads2k @liggitt @k8s-ci-robot